let TVariable generics extend OperationVariables

[phryneas]

to accommodate an upstream type change in @apollo/[email protected]

This addresses #1907

Checklist:

• If this PR is a new feature, please reference a discussion where a consensus about the design was reached (not necessary for small changes)
• Make sure all the significant new logic is covered by tests
• Try to include the Pull Request inside of CHANGELOG.md

[changeset-bot]

🦋 Changeset detected

Latest commit: ad5340f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
apollo-angular	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[PowerKiKi]

According to CI, you might have forgotten a few usages...

[PowerKiKi]

This definitely should use ^ notation, and probably be ^3.7.7

[phryneas]

Sure, I just wanted to stick to existing patterns :)

[PowerKiKi]

In an ideal world apollo-client would have released a major version, because it was breaking, and we would also have to release a major version. But since they released as patch version, we probably also should release as patch, not minor, shouldn't we ?

[phryneas]

Oh, sorry! I had only run tsc in the package folder and assumed that would be enough to catch everything.

I already finished up for the day - I'll get back to this and fix up the rest tomorrow.

[phryneas]

Okay, next turn in the CI :)

Generally, these are hard to catch, since they don't turn up in the repo itself (which has strict: false), but only if used in other projects (as the CI does) with a different tsconfig and skipLibChecks: false.
Let's hope I did get all usages now.

I didn't turn on strict: true for the repo since that results in a big batch of unrelated strictNullCheck-caused errors, but personally I would really want to encourage you to make that change in the future, since this might reoccur - consuming projects with a more strict tsconfig and skipLibChecks: false might run into issues with this. (Also, strict: true is how the TS team intends TS to be used)

[PowerKiKi]

100% agree we must switch to strict typescript as soon as possible. I was not aware we were not strict yet.

[phryneas]

Looks like it's al green now :) Yay!

[PowerKiKi]

Thank you taking the time to fix this ❤️