Upgrades to TypeScript 4.9.4

[alessbell]

Branched off of #10305 which itself branched off of #9919.

Upgrades from TS 4.7.4 to 4.9.4 and makes relevant fixes (see #9199).

Checklist:

• If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
• If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests

[changeset-bot]

🦋 Changeset detected

Latest commit: 4e18792

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[jerelmiller]

This is fantastic! Thanks for helping shepard this along.

I had a few comments in regards to the {} type that I'd like to check on, but otherwise this looks great!

[alessbell]

Right now, all of these changes are backward-compatible, except the changes to the HOC interfaces, hence having to update significant test code in that part of the codebase.

I'd like to take a closer look at those, but won't be able to prioritize it for a week or so (we can also target this for 4.0 if that eventually seems to make more sense, but I'd like to avoid that if possible). Leaving this PR open in the meantime.

Edit: I've resolved the HOC type issues, this is good to go 🎉

[jerelmiller]

This looks great to me. Thanks for handling this!

[PowerKiKi]

This is a breaking change for TypeScript users and should probably have been released in a major version, or at least mentioned in the changelog.

[phryneas]

OperationVariables is defined as Record<string, any>, so this only makes sure what you pass in as TVariables is an object, and not a primitive value like string, which would (afaik) always have caused a runtime error in the past. So I would not see it as a breaking change, but more the types getting closer to existing runtime behaviour.
To make sure I'm not missing something: Can you think of anything that could have been used here in the past that would not have caused a runtime error?

[PowerKiKi]

I get what you are saying, and I agree that there is no runtime breaking change. But for TypeScript users a change of type might mean a compile time breaking change. And turns out it did break compilation for a bunch of users: kamilkisiela/apollo-angular#1907

But I get it, it's not a huge change, and not such as terrible thing to deal with for us. But still, it creates a bit of friction. I thought you might want to hear about it, so maybe you could handle it differently for future cases (or not, that's up to you 😅 )

[phryneas]

Yeah, I was explicitly asking for situations where this could break at all - and you are right, non-restricted, yet-unresolved generic arguments that are forwarded are impacted by this - essentially, this can occur if you wrap the type or a usage of the type with your own generalized implementation. I didn't think of that use case.
As this is out right now, I don't think we should go "back" on it in this specific use case - especially since it might block users from upgrading their TypeScript version (this was changed for a reason, after all).

But yes, generally, we are trying to keep TypeScript changes that could break things in user code out of patch releases and at least target minor versions with them. Targeting major versions is sometimes not feasible, since we have long iterations here and TypeScript itself is just advancing very fast. But we will try to communicate it better in the future.

As for the problem at hand: fixing this requires that you add the same constraint on your end, so this change will be required:

-export class QueryRef<T, V = EmptyObject> {
+export class QueryRef<T, V extends OperationVariables = EmptyObject> {

I will see that I file a PR on your side to reduce friction.

[phryneas]

@PowerKiKi there you go :) kamilkisiela/apollo-angular#1910

[PowerKiKi]

thanks for the PR ! I didn't realize that it was you who made it.

And don't worry for going "back". I didn't expect you to do anything more than just listening to my rant 😅