Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: set accounts with empty code but non-empty storage as EOA #247

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

ulbqb
Copy link
Contributor

@ulbqb ulbqb commented Feb 3, 2025

Proposed changes

EEST has accounts which have empty code but non-empty storage as the pre state. Kaia should recognize the following:

  • account with delegation code and fork is prague → EOA
  • account with empty code but non-empty storage and fork is prague → EOA
  • account with non-empty code except for delegation code → SCA
  • otherwise → as is

This PR enables to recognize accounts with empty code but non-empty storage as EOA.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

}
}

if len(a.Code) != 0 {
statedb.SetCode(addr, a.Code)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but does EOA with delegation code work? Don't we need to call SetCodeToEOA somewhere?

@ulbqb ulbqb requested a review from tnasu February 4, 2025 02:27
@ulbqb ulbqb changed the title tests: fix MakePreState tests: set accounts with empty code but non-empty storage as EOA Feb 4, 2025
@ulbqb ulbqb merged commit 1469478 into kaiachain:dev Feb 4, 2025
11 checks passed
@ulbqb ulbqb deleted the fix/make_pre_state branch February 4, 2025 05:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants