feat: Use uint256 for chainId and return delegation designator for EXTCODE* in SET_CODE_TX_TYPE(EIP-7702) #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeonLewis
reviewed
Feb 3, 2025
hyeonLewis
reviewed
Feb 3, 2025
hyeonLewis
previously approved these changes
Feb 3, 2025
ulbqb
previously approved these changes
Feb 3, 2025
hyeonLewis
previously approved these changes
Feb 3, 2025
blukat29
previously approved these changes
Feb 4, 2025
ethereum/go-ethereum#31089 ---- relates: kaiachain@5eeb56c * core/vm: return delegation designator prefix for code reading ops * ethereum/go-ethereum@fdfc159
ethereum/go-ethereum@1506e06 core/types: improve authority signature handling ethereum/go-ethereum@bb182a6 tests: use big int for stAuthorization because eest needs math.HexOrDecimal256 decoding ethereum/go-ethereum@6505e50
tnasu
dismissed stale reviews from blukat29, hyeonLewis, and ulbqb
via
8a34522
tnasu
force-pushed
the
dev-update-eip7702-chainid
branch
from
7b103d9 to
8a34522
Compare
blukat29
approved these changes
Feb 4, 2025
ulbqb
approved these changes
Feb 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Changes:
uint256forSET_CODE_TX_TYPE(EIP-7702)EXTCODE*return delegation designator forSET_CODE_TX_TYPE(EIP-7702)Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLAin first time contribute$ make test)Related issues
Further comments