blockchain: make a genesis block according to forks #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ulbqb
force-pushed
the
fix/genesis_toblock
branch
from
ec909e9 to
8c57216
Compare
ulbqb
changed the title
ulbqb
changed the title
ulbqb
requested review from
tnasu,
hyunsooda,
2dvorak,
shiki-tak and
Mdaiki0730
Mdaiki0730
reviewed
Feb 4, 2025
|
How about clearly indicating in the code that the code diff from this PR does not affect the production (test) environment and is for testing purposes? Or adding a link to this PR in the code? |
|
@shiki-tak |
hyunsooda
reviewed
Feb 6, 2025
Comment on lines
+325
to
+329
| // If account.Code is nil and originalCode is not nil, | ||
| // just update the code and don't change the other states | ||
| if len(account.Code) != 0 && originalCode != nil { | ||
| logger.Warn("this address already has a not nil code, now the code of this address has been changed", "addr", addr.String()) | ||
| continue |
There was a problem hiding this comment.
Looks like this can be checked first before L316-322.
There was a problem hiding this comment.
I can't do that. I want to do continue after setting code if an original code exists.
blukat29
reviewed
Feb 6, 2025
Co-authored-by: Yunjong Jeong (ollie) <[email protected]>
Mdaiki0730
reviewed
Feb 6, 2025
Co-authored-by: murogari <[email protected]>
ian0371
approved these changes
Feb 6, 2025
hyeonLewis
approved these changes
Feb 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR enables to make genesis blocks according to forks. This may have braking change in the case where the fork of genesis is Istanbul fork and after because this changes the state root of genesis by changing codeinfo of SCA (version 0 into version 1). But there is no effect against mainnet and testnet because the genesis doesn't have any forks. You can see the state roof of genesis doesn't change in this test.
This stores genesis accounts like bellow:
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLAin first time contribute$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...