Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kaia units #3

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Conversation

nohkwak
Copy link

@nohkwak nohkwak commented Jun 27, 2024

Proposed changes

  • Remove submodules for conformance-test and integration-test
  • Support kei, Gkei, KAIA units (Added functions : fromKei, toKei, convertFromKei, convertToKei)

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • N/A

Further comments

  • N/A

Copy link

github-actions bot commented Jun 27, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nohkwak
Copy link
Author

nohkwak commented Jun 27, 2024

I have read the CLA Document and I hereby sign the CLA

@nohkwak nohkwak mentioned this pull request Jun 27, 2024
9 tasks
@nohkwak nohkwak merged commit d17f528 into kaiachain:dev Jun 27, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants