Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Kaia Units #1

Closed
wants to merge 2 commits into from
Closed

Support Kaia Units #1

wants to merge 2 commits into from

Conversation

nohkwak
Copy link

@nohkwak nohkwak commented Jun 10, 2024

Proposed changes

  • Support kei, Gkei, KAIA units
  • Added functions : fromKei, toKei, convertFromKei, convertToKei

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • N/A

Further comments

  • N/A

@nohkwak
Copy link
Author

nohkwak commented Jun 24, 2024

I have read the CLA Document and I hereby sign the CLA

@JayChoi1736
Copy link
Contributor

could you set wrapper function for new convert function in UiltsWrapper.java?

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
@nohkwak
Copy link
Author

nohkwak commented Jun 27, 2024

could you set wrapper function for new convert function in UiltsWrapper.java?

@JayChoi1736
I updated in #3
Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JayChoi1736 JayChoi1736 JayChoi1736 approved these changes

Assignees

@nohkwak nohkwak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nohkwak @JayChoi1736 @Sotatek-TuLe2