Added trailing 0 to ipv6 ranges that end in ":" #297
Conversation
ipv6 ranges ending in a colon, such as a trail of zeroes denoted by "::" result in the storage engine failing to process the range, because ranges are expected to begin and end with alphanumerical characters to meet CRD requirements. Thus we append a 0 to any ranges that meet this criteria because it is functionally equivalent. Signed-off-by: nicklesimba <[email protected]>
There was a problem hiding this comment.
Totally on board with this change! Can we add a test that ends with a ::?
Add another test near this one / like this one: https://github.com/k8snetworkplumbingwg/whereabouts/blob/master/cmd/whereabouts_test.go#L223-L235
cmd/whereabouts_test.go
Outdated
| It("allocates and releases an IPv6 range that ends with zeroes with a Kubernetes backend", func() { | ||
|
|
||
| ipVersion := "6" | ||
| ipRange := "2001:1b74:480:603d:0304:0403:000:0000-2001:1b74:480:603d:0304:0403:0000:0004/64" |
There was a problem hiding this comment.
Let's use a documentation range, so make the range start with 2001:db8
Also, add an additional test that doesn't just ends with zeros, but another one that ends with :: literally so, for example.... 2001:db8:b33f::/48 or something
There was a problem hiding this comment.
nicklesimba
force-pushed
the
invalid-ipv6-bz
branch
from
de780ee to
b9dcad9
Compare
|
Looks good, I think we just need a rebase (there's a merge commit from master in here) |
Signed-off-by: nicklesimba <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
nicklesimba
force-pushed
the
invalid-ipv6-bz
branch
from
51bbe16 to
7c6639a
Compare
Signed-off-by: Miguel Duarte Barroso <[email protected]>
nicklesimba
force-pushed
the
invalid-ipv6-bz
branch
from
7c6639a to
f5469ae
Compare
|
wait, this merged a golang upgrade to 1.19. Do we want to do that ? Not saying I'm against it, but we probably should have merged #294 instead first. |
|
@dougbtv can we cherry-pick this fix to v0.6 and v0.5? we dont have v0.6 branch can we have a patch release v0.6.1? |
What this PR does / why we need it:
ipv6 ranges ending in a colon, such as a trail of zeroes denoted by "::" result in the storage engine failing to process the range, because ranges are expected to begin and end with alphanumerical characters to meet CRD requirements. Thus we append a 0 to any ranges that meet this criteria because it is functionally equivalent and meets the requirements.
Signed-off-by: nicklesimba [email protected]
Which issue(s) this PR fixes:
Fixes #263, fixes #293
Special notes for your reviewer (optional):
https://imgs.xkcd.com/comics/networking_problems.png