Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to 1.19 #294

Closed
wants to merge 3 commits into from
Closed

Bump Go version to 1.19 #294

wants to merge 3 commits into from

Conversation

pjbgf
Copy link
Contributor

@pjbgf pjbgf commented Jan 17, 2023

What this PR does / why we need it:

Bumps Go version to 1.19 and removes usage of package io/ioutil which is deprecated since Go 1.16.

Supersedes #271.

@pjbgf pjbgf requested review from maiqueb and dougbtv as code owners January 17, 2023 14:53
Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will merge once golang 1.18 goes EOL.

@maiqueb
Copy link
Collaborator

maiqueb commented Jan 17, 2023

Seems you need to also bump the code generators @pjbgf .
https://github.com/k8snetworkplumbingwg/whereabouts/actions/runs/3940430333/jobs/6741685662

@pjbgf
Copy link
Contributor Author

pjbgf commented Jan 17, 2023

@maiqueb thanks for pointing it out, I updated zz_generated.deepcopy.go and also made sure that the boilerplate across the generated files were also updated.

@maiqueb
Copy link
Collaborator

maiqueb commented Feb 8, 2023

Oh man, sorry, but your code was mistakenly merged as part of #297 ...

I hope you do get the contribution stats.
@pjbgf

@nicklesimba
Copy link
Collaborator

@pjbgf Hey, apologies that we didn't get your PR merged -- probably should have gotten your PR merged first. Your commits have made it into master branch however. I'll close out this PR. I appreciate your contribution!

@nicklesimba nicklesimba closed this Feb 8, 2023
@pjbgf
Copy link
Contributor Author

pjbgf commented Feb 9, 2023

@maiqueb @nicklesimba no worries, thank you for the heads up. 👍

@pjbgf pjbgf deleted the bump-deps branch February 9, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants