check version incompatibility (#762) #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* multus: entrypoint: disallow incompatible cni versions When top level CNI version is 0.4.0 or more, nested CNI version can't be less than 0.4.0 since these are incompatible. This closes issue k8snetworkplumbingwg#737. Signed-off-by: Balazs Nemeth <[email protected]> * multus: thick: disallow incompatible cni versions Similarly to disallowing incompatible versions in entrypoint.sh, add the same logic in go for the thick plugin. Signed-off-by: Balazs Nemeth <[email protected]> * multus: add unit test for incompatible cni versions Signed-off-by: Balazs Nemeth <[email protected]>
Pull Request Test Coverage Report for Build 1910331057
💛 - Coveralls |
s1061123
added a commit
that referenced
this pull request
Apr 5, 2022
* multus: entrypoint: disallow incompatible cni versions When top level CNI version is 0.4.0 or more, nested CNI version can't be less than 0.4.0 since these are incompatible. This closes issue #737. Signed-off-by: Balazs Nemeth <[email protected]> * multus: thick: disallow incompatible cni versions Similarly to disallowing incompatible versions in entrypoint.sh, add the same logic in go for the thick plugin. Signed-off-by: Balazs Nemeth <[email protected]> * multus: add unit test for incompatible cni versions Signed-off-by: Balazs Nemeth <[email protected]> Co-authored-by: Balazs Nemeth <[email protected]>
cruizen
pushed a commit
to platform9/multus-cni
that referenced
this pull request
Apr 11, 2024
…lumbingwg#798) * multus: entrypoint: disallow incompatible cni versions When top level CNI version is 0.4.0 or more, nested CNI version can't be less than 0.4.0 since these are incompatible. This closes issue k8snetworkplumbingwg#737. Signed-off-by: Balazs Nemeth <[email protected]> * multus: thick: disallow incompatible cni versions Similarly to disallowing incompatible versions in entrypoint.sh, add the same logic in go for the thick plugin. Signed-off-by: Balazs Nemeth <[email protected]> * multus: add unit test for incompatible cni versions Signed-off-by: Balazs Nemeth <[email protected]> Co-authored-by: Balazs Nemeth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a cherry-pikck #762 to 4.0 branch