Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interworking with 0.4.0 and 0.3.1 (or previous) CNI version #737

Closed
s1061123 opened this issue Oct 15, 2021 · 2 comments
Closed

Interworking with 0.4.0 and 0.3.1 (or previous) CNI version #737

s1061123 opened this issue Oct 15, 2021 · 2 comments
Labels

Comments

@s1061123
Copy link
Member

Since CNI version 0.4.0, CHECK command is introduced. If user configures multus config as follows, then CHECK command will be sent to delegate CNI, flannel and we get error message from kubelet.

What should we do for that...

[fedora@kube-master1 ~]$ sudo cat /etc/cni/net.d/00-multus.conf  | jq
{
  "cniVersion": "0.4.0",
  "name": "multus-cni-network",
  "type": "multus",
  "capabilities": {
    "portMappings": true
  },
  "logLevel": "debug",
  "logFile": "/tmp/multus.log",
  "kubeconfig": "/etc/cni/net.d/multus.d/multus.kubeconfig",
  "delegates": [
    {
      "name": "cbr0",
      "cniVersion": "0.3.1",
      "plugins": [
        {
          "type": "flannel",
          "delegate": {
            "hairpinMode": true,
            "isDefaultGateway": true
          }
        },
        {
          "type": "portmap",
          "capabilities": {
            "portMappings": true
          }
        }
      ]
    }
  ]
}

  Warning  FailedCreatePodSandBox  2s    kubelet            Failed to create pod sandbox: rpc error: code = Unknown desc = failed to get network status for pod sandbox k8s_fedora-nonet_default_888e2e8f-4551-46d2-858a-87e5bbeb31e7_0(457da3c23a303d35c61737e78f5a7a2996f881516ab3dcd4f84382943928b42c): delegateCheck: error invoking ConflistCheck - "cbr0": conflistCheck: error in getting result from CheckNetworkList: configuration version "0.3.1" does not support the CHECK command
@dougbtv
Copy link
Member

dougbtv commented Oct 28, 2021

We should not accept 0.3.1 or earlier in the case of 0.4.0 at the top level config. May need to be implemented in entrypoint.

bn222 added a commit to bn222/multus-cni that referenced this issue Nov 19, 2021
When nested CNI version is 0.3.1 or less while the top level CNI version
is 0.4.0, error out. Version 0.3.1 or less doesn't support the CHECK
command. This closes issue k8snetworkplumbingwg#737.
bn222 added a commit to bn222/multus-cni that referenced this issue Dec 14, 2021
When nested CNI version is 0.3.1 or less while the top level CNI version
is 0.4.0, error out. Version 0.3.1 or less doesn't support the CHECK
command. This closes issue k8snetworkplumbingwg#737.
bn222 added a commit to bn222/multus-cni that referenced this issue Dec 14, 2021
When nested CNI version is 0.3.1 or less while the top level CNI version
is 0.4.0, error out. Version 0.3.1 or less doesn't support the CHECK
command. This closes issue k8snetworkplumbingwg#737.
bn222 added a commit to bn222/multus-cni that referenced this issue Jan 4, 2022
When top level CNI version is 0.4.0 or more, nested CNI version
can't be less than 0.4.0 since these are incompatible. This
closes issue k8snetworkplumbingwg#737.

Signed-off-by: Balazs Nemeth <[email protected]>
bn222 added a commit to bn222/multus-cni that referenced this issue Jan 13, 2022
When top level CNI version is 0.4.0 or more, nested CNI version
can't be less than 0.4.0 since these are incompatible. This
closes issue k8snetworkplumbingwg#737.

Signed-off-by: Balazs Nemeth <[email protected]>
@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 27, 2022
@github-actions github-actions bot closed this as completed Feb 4, 2022
s1061123 pushed a commit that referenced this issue Feb 28, 2022
* multus: entrypoint: disallow incompatible cni versions

When top level CNI version is 0.4.0 or more, nested CNI version
can't be less than 0.4.0 since these are incompatible. This
closes issue #737.

Signed-off-by: Balazs Nemeth <[email protected]>

* multus: thick: disallow incompatible cni versions

Similarly to disallowing incompatible versions in entrypoint.sh,
add the same logic in go for the thick plugin.

Signed-off-by: Balazs Nemeth <[email protected]>

* multus: add unit test for incompatible cni versions

Signed-off-by: Balazs Nemeth <[email protected]>
s1061123 pushed a commit to s1061123/multus-cni that referenced this issue Feb 28, 2022
* multus: entrypoint: disallow incompatible cni versions

When top level CNI version is 0.4.0 or more, nested CNI version
can't be less than 0.4.0 since these are incompatible. This
closes issue k8snetworkplumbingwg#737.

Signed-off-by: Balazs Nemeth <[email protected]>

* multus: thick: disallow incompatible cni versions

Similarly to disallowing incompatible versions in entrypoint.sh,
add the same logic in go for the thick plugin.

Signed-off-by: Balazs Nemeth <[email protected]>

* multus: add unit test for incompatible cni versions

Signed-off-by: Balazs Nemeth <[email protected]>
s1061123 added a commit that referenced this issue Feb 28, 2022
* multus: entrypoint: disallow incompatible cni versions

When top level CNI version is 0.4.0 or more, nested CNI version
can't be less than 0.4.0 since these are incompatible. This
closes issue #737.

Signed-off-by: Balazs Nemeth <[email protected]>

* multus: thick: disallow incompatible cni versions

Similarly to disallowing incompatible versions in entrypoint.sh,
add the same logic in go for the thick plugin.

Signed-off-by: Balazs Nemeth <[email protected]>

* multus: add unit test for incompatible cni versions

Signed-off-by: Balazs Nemeth <[email protected]>

Co-authored-by: Balazs Nemeth <[email protected]>
s1061123 added a commit that referenced this issue Apr 5, 2022
* multus: entrypoint: disallow incompatible cni versions

When top level CNI version is 0.4.0 or more, nested CNI version
can't be less than 0.4.0 since these are incompatible. This
closes issue #737.

Signed-off-by: Balazs Nemeth <[email protected]>

* multus: thick: disallow incompatible cni versions

Similarly to disallowing incompatible versions in entrypoint.sh,
add the same logic in go for the thick plugin.

Signed-off-by: Balazs Nemeth <[email protected]>

* multus: add unit test for incompatible cni versions

Signed-off-by: Balazs Nemeth <[email protected]>

Co-authored-by: Balazs Nemeth <[email protected]>
cruizen pushed a commit to platform9/multus-cni that referenced this issue Apr 11, 2024
* multus: entrypoint: disallow incompatible cni versions

When top level CNI version is 0.4.0 or more, nested CNI version
can't be less than 0.4.0 since these are incompatible. This
closes issue k8snetworkplumbingwg#737.

Signed-off-by: Balazs Nemeth <[email protected]>

* multus: thick: disallow incompatible cni versions

Similarly to disallowing incompatible versions in entrypoint.sh,
add the same logic in go for the thick plugin.

Signed-off-by: Balazs Nemeth <[email protected]>

* multus: add unit test for incompatible cni versions

Signed-off-by: Balazs Nemeth <[email protected]>
cruizen pushed a commit to platform9/multus-cni that referenced this issue Apr 11, 2024
…lumbingwg#798)

* multus: entrypoint: disallow incompatible cni versions

When top level CNI version is 0.4.0 or more, nested CNI version
can't be less than 0.4.0 since these are incompatible. This
closes issue k8snetworkplumbingwg#737.

Signed-off-by: Balazs Nemeth <[email protected]>

* multus: thick: disallow incompatible cni versions

Similarly to disallowing incompatible versions in entrypoint.sh,
add the same logic in go for the thick plugin.

Signed-off-by: Balazs Nemeth <[email protected]>

* multus: add unit test for incompatible cni versions

Signed-off-by: Balazs Nemeth <[email protected]>

Co-authored-by: Balazs Nemeth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants