Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change coredns extra_plugins to array type #1510

Merged
merged 3 commits into from
May 15, 2024
Merged

Change coredns extra_plugins to array type #1510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbaf62b
fixes 1267
infbase Mar 22, 2024
e8834dd
fix faulty values.yaml
infbase Mar 22, 2024
7e47699
changed extra_plugins default value to empty array as that is a bette…
infbase Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion chart/k8gb/templates/coredns-cm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ data:
errors
health
{{- if .Values.k8gb.coredns.extra_plugins }}
{{ .Values.k8gb.coredns.extra_plugins | indent 8}}
{{- range .Values.k8gb.coredns.extra_plugins }}
{{ . }}
{{- end }}
{{- end }}
ready
prometheus 0.0.0.0:9153
Expand Down
5 changes: 4 additions & 1 deletion chart/k8gb/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,10 @@
"additionalProperties": false,
"properties": {
"extra_plugins": {
"type": "string"
"type": [
"array",
"null"
]
}
},
"title": "k8gbCoredns"
Expand Down
2 changes: 1 addition & 1 deletion chart/k8gb/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ k8gb:
reconcileRequeueSeconds: 30
# -- Extra CoreDNS plugins to be enabled (yaml object)
coredns:
extra_plugins: ""
extra_plugins: []
log:
# -- log format (simple,json)
format: simple # log format (simple,json)
Expand Down
Loading