Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change coredns extra_plugins to array type #1510

Merged
merged 3 commits into from
May 15, 2024

Conversation

infbase
Copy link
Contributor

@infbase infbase commented Mar 22, 2024

  • Specify extra_plugins of coredns as array instead of plain string

  • Adjust schema

  • Enables more intuitive and convenient plugin specification, e.g

coredns:
    extra_plugins:
      - log
      - prometheus

..

HOW TO RUN CI ---

By default, all the checks will be run automatically. Furthermore, when changing website-related stuff, the preview will be generated by the netlify bot.

Heavy tests

Add the heavy-tests label on this PR if you want full-blown tests that include more than 2-cluster scenarios.

Debug tests

If the test suite is failing for you, you may want to try triggering Re-run all jobs (top right) with debug logging enabled. It will also make the print debug action more verbose.

Signed-off-by: Nuno Guedes <[email protected]>
@ytsarev
Copy link
Member

ytsarev commented Apr 17, 2024

@kuritka @k0da , guys, I need your review here. do you use original string representation to construct the Corefile config?

@k0da
Copy link
Collaborator

k0da commented May 15, 2024

LGTM

@k0da k0da merged commit c2b799e into k8gb-io:master May 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HelmChart values validations
4 participants