[release-1.26] Backports for 2024-01 k3s2 #9338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix issue with bare host or IP as endpoint * Fix issue with localhost registries not defaulting to http. * Move the registry template prep to a separate function, and adds tests of that function so that we can ensure we're generating the correct content. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
2024-01-k3s2-backports_release-1.26
branch
2 times, most recently
from
2e8f519 to
e9a52e3
Compare
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
2024-01-k3s2-backports_release-1.26
branch
from
e9a52e3 to
22608d8
Compare
vitorsavian
approved these changes
Feb 1, 2024
VestigeJ
approved these changes
Feb 1, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-1.26 #9338 +/- ##
================================================
+ Coverage 14.23% 14.98% +0.74%
================================================
Files 115 115
Lines 8389 8430 +41
================================================
+ Hits 1194 1263 +69
+ Misses 6955 6918 -37
- Partials 240 249 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Backports:
Types of Changes
version bump, bugfix, backport
Verification
See linked PRs
Testing
Linked Issues
User-Facing Change
Further Comments