-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump runc to v1.1.12 and helm-controller to v0.15.7 #9332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LETS GO 💚
Sorry if I don't understand the code, but it appears that runc is being bumped to 1.1.11 instead of 1.1.12 |
Yes, this is still WIP. |
257caa7
to
885d47d
Compare
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9332 +/- ##
==========================================
- Coverage 45.68% 41.07% -4.62%
==========================================
Files 154 154
Lines 16622 16623 +1
==========================================
- Hits 7594 6828 -766
- Misses 7815 8641 +826
+ Partials 1213 1154 -59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Proposed Changes
Bump runc and helm-controller versions
Also applies
gofmt -s
changes to test file added in #9323. Master has gofmt checks disabled but other branches do not and are failing CI.Types of Changes
version bump
Verification
check versions
Testing
Linked Issues
User-Facing Change
Further Comments
NOTE: This switches to a fork of runc due to opencontainers/runc@0c8e2cc breaking Windows platform cross-builds of things that pull in runc/libcontainer. The fix is in k3s-io/runc@7d07dac