Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump runc to v1.1.12 and helm-controller to v0.15.7 #9332

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Feb 1, 2024

Proposed Changes

Bump runc and helm-controller versions

Also applies gofmt -s changes to test file added in #9323. Master has gofmt checks disabled but other branches do not and are failing CI.

Types of Changes

version bump

Verification

check versions

Testing

Linked Issues

User-Facing Change


Further Comments

NOTE: This switches to a fork of runc due to opencontainers/runc@0c8e2cc breaking Windows platform cross-builds of things that pull in runc/libcontainer. The fix is in k3s-io/runc@7d07dac

dereknola
dereknola previously approved these changes Feb 1, 2024
VestigeJ
VestigeJ previously approved these changes Feb 1, 2024
Copy link

@VestigeJ VestigeJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LETS GO 💚

@ghoff
Copy link

ghoff commented Feb 1, 2024

Sorry if I don't understand the code, but it appears that runc is being bumped to 1.1.11 instead of 1.1.12

@brandond brandond dismissed stale reviews from VestigeJ and dereknola via 6946c71 February 1, 2024 18:43
@brandond brandond changed the title Bump runc to v1.1.12 and helm-controller to v0.15.6 Bump runc to v1.1.12 and helm-controller to v0.15.7 Feb 1, 2024
@brandond
Copy link
Member Author

brandond commented Feb 1, 2024

Yes, this is still WIP.

@brandond brandond force-pushed the bump_runc branch 2 times, most recently from 257caa7 to 885d47d Compare February 1, 2024 19:55
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29848de) 45.68% compared to head (28efdde) 41.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9332      +/-   ##
==========================================
- Coverage   45.68%   41.07%   -4.62%     
==========================================
  Files         154      154              
  Lines       16622    16623       +1     
==========================================
- Hits         7594     6828     -766     
- Misses       7815     8641     +826     
+ Partials     1213     1154      -59     
Flag Coverage Δ
e2etests ?
inttests 37.59% <100.00%> (+0.01%) ⬆️
unittests 15.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit c635818 into k3s-io:master Feb 2, 2024
15 checks passed
@brandond brandond deleted the bump_runc branch June 6, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants