Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added gitlab URL #1577

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Added gitlab URL #1577

merged 2 commits into from
Feb 17, 2020

Conversation

metonymic-smokey
Copy link
Contributor

WIP PR for issue #1569. Will continue till it LGTM.

@metonymic-smokey metonymic-smokey changed the title added blank URL [WIP] added gitlab URL Feb 16, 2020
consideRatio
consideRatio approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using none, it will later assume the configuration in config.yaml is gitlabUrl, all good!

I could merge this as it is, just remove the WIP and ill do so the next time i look!

If possible, avoid all changes other than those that matters such as introducing spaces above. I do git diff quite often to avoid unnecessary changes.

I'd order the entries alphabetically, because why not, but it doesnt really matter of course :)

@metonymic-smokey
Copy link
Contributor Author

@consideRatio Thanks a lot for your inputs!
Will start using git diff now that I've learnt about it!

Thanks!

@metonymic-smokey metonymic-smokey changed the title [WIP] added gitlab URL Added gitlab URL Feb 17, 2020
@consideRatio
Copy link
Member

Thank you @metonymic-smokey!! ❤️

Hey also, in github, if you write "fixes #issuenumber" in tge main post, it will close an issue when the PR is merged. Ill manually close the relates issue now though. Thanks again for your work!! 🎉

@consideRatio consideRatio merged commit d7181a6 into jupyterhub:master Feb 17, 2020
@metonymic-smokey
Copy link
Contributor Author

@consideRatio Thanks for the many tips! I will keep them in mind for future PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metonymic-smokey @consideRatio