Add gitlab_url trait to the chart

[rprimet]

Looking at the gitlab-specific configuration section in the chart (

zero-to-jupyterhub-k8s/jupyterhub/files/hub/jupyterhub_config.py

Lines 287 to 295 in f14134c

	elif auth_type == 'gitlab':
	c.JupyterHub.authenticator_class = 'oauthenticator.gitlab.GitLabOAuthenticator'
	for trait, cfg_key in common_oauth_traits + (
	('gitlab_group_whitelist', None),
	('gitlab_project_id_whitelist', None),
	):
	if cfg_key is None:
	cfg_key = camelCaseify(trait)
	set_config_if_not_none(c.GitLabOAuthenticator, trait, 'auth.gitlab.' + cfg_key)

), it seems that the gitlab_url trait is missing from the list of configurable gitlab-specific traits.

Adding it would allow configuring a custom gitlab instance without resorting to python snippets.

[metonymic-smokey]

@rprimet I'll make an attempt to figure this out.
From what I understood, you want the gitlab_url trait to be added to the existing traits like gitlab_group_whitelist and gitlab_project_id_whitelist right?
Is there anything I've missed?

[rprimet]

@metonymic-smokey Yes that's it!

[metonymic-smokey]

@rprimet I have a query about this issue.
In this WIP PR, I have used None as the cfg_key for the gitlab_url trait. I am not exactly sure if that's right/what value I should be using there.
Would love your inputs on the same!

Thanks!

[consideRatio]

Thanks @rprimet and @metonymic-smokey for reporting and fixing this!