Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up jupyter releaser #1577

Merged
merged 24 commits into from
May 18, 2022
Merged

Set up jupyter releaser #1577

merged 24 commits into from
May 18, 2022

Conversation

brichet
Copy link
Contributor

@brichet brichet commented May 9, 2022 •
edited
Loading

This PR aims to use jupyter releaser for futures releases of nbgrader (#1570)

  • uses setup.cfg file
  • adds check-release workflow in CI
  • inits tbump
  • moves changelog from documentation directory to root directory

@jtpio jtpio added this to the 0.8.0 milestone May 9, 2022
@jtpio
Copy link
Member

jtpio commented May 9, 2022

Thanks @brichet for starting this!

davidbrochart
davidbrochart reviewed May 9, 2022
View reviewed changes
jtpio
jtpio reviewed May 10, 2022
View reviewed changes
@jtpio
Copy link
Member

jtpio commented May 11, 2022

Nice, looks like CI is now passing 🎉

@jtpio jtpio mentioned this pull request May 11, 2022
Closed
jtpio
jtpio reviewed May 11, 2022
View reviewed changes
Nicolas Brichet added 3 commits May 12, 2022 09:56
(1) switch to 0.8.0.dev version, (2) remove duplicate information in …
35ed7aa 
…pyproject.toml file, (3) add github workflow to upload artifact and (4) fix traitlets dependency (version 5.2.0 breaks tests)
Modify CHANGELOG.md and _version.py files accordingly to jupyter_rele…
8cac4b0 
…aser needs
Increase timeout for windows/nbextension tests
feff903
@jtpio jtpio closed this May 12, 2022
@jtpio jtpio reopened this May 12, 2022
@jtpio
Copy link
Member

jtpio commented May 12, 2022

Kicking CI to try to get the ReadTheDocs preview: #1580

@brichet
Copy link
Contributor Author

brichet commented May 13, 2022 •
edited
Loading

Nice, thanks @jtpio for reviews.
The documentation still needs to be updated with the use of jupyter_releaser and tbump.
I think we can merge this PR and open an issue on the documentation.

jtpio
jtpio reviewed May 13, 2022
View reviewed changes
jtpio
jtpio approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

Just checked the built assets uploaded as artifact and the version seems to be bumped correctly there.

@jtpio
Copy link
Member

jtpio commented May 16, 2022

cc @jhamrick who did the previous releases and might want to have a look too

@jtpio jtpio linked an issue May 17, 2022 that may be closed by this pull request
Adopt the Jupyter Releaser #1570
Closed
jhamrick
jhamrick approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@jhamrick jhamrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot!

@jtpio
Copy link
Member

jtpio commented May 17, 2022 •
edited
Loading

Thanks @brichet, @jhamrick and @davidbrochart!

@jtpio jtpio merged commit 12badfe into jupyter:master May 18, 2022
@brichet brichet deleted the set_up_jupyter_releaser branch May 19, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart left review comments

@jhamrick jhamrick jhamrick approved these changes

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Adopt the Jupyter Releaser
4 participants
@brichet @jtpio @jhamrick @davidbrochart