Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the Jupyter Releaser #1570

Closed
jtpio opened this issue May 4, 2022 · 3 comments · Fixed by #1577
Closed

Adopt the Jupyter Releaser #1570

jtpio opened this issue May 4, 2022 · 3 comments · Fixed by #1577
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented May 4, 2022

It would be great if we could start using the Jupyter Releaser for making new releases: https://jupyter-releaser.readthedocs.io/en/latest/

The releaser is already being used in many projects. Using it for nbgrader would be great for consistency and would make the setup similar to the other projects.

The checklist for adoption: https://jupyter-releaser.readthedocs.io/en/latest/how_to_guides/convert_repo.html

@jhamrick
Copy link
Member

jhamrick commented May 5, 2022

That's a great idea, I didn't know about Jupyter Releaser.

If you start using it could you update the releasing docs accordingly too? (They may also be helpful in ensuring all the release steps are followed when switching to Jupyter Releaser): https://nbgrader.readthedocs.io/en/stable/contributor_guide/releasing.html

@jhamrick jhamrick added this to the 0.8.0 milestone May 5, 2022
@brichet
Copy link
Contributor

brichet commented May 9, 2022

I can start setting up the Jupyter Releaser.
I don't know if I need special permissions on this repository. I'll let you know.

@jtpio
Copy link
Member Author

jtpio commented May 9, 2022

Thanks @brichet.

We should be able to start with a draft PR, by adding the config files and the check-release CI workflow like that one: https://github.com/jupyter-server/jupyter_server/blob/main/.github/workflows/check-release.yml

The check release workflow will help us know if the repo is correctly setup and ready to be released with the releaser.

@jtpio jtpio linked a pull request May 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants