-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to overwrite the highlight_code filter #877
Add option to overwrite the highlight_code filter #877
Conversation
Updated release instructions based on 5.4 release walk-through
DOC: Add missing language specification to code-block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Sorry no one was reviewing this for a bit. I'll try to contribute some more reviews now and then.
One thing to ask is if you could make a trivial test to prove filters get overwritten when we use this, it'd help keep the code quality up over time. Thanks!
Thanks for the review Mathew. I made the change you requested and added a small test. |
…g/nbconvert into overwrite-highlight_code-filter
Ok, I finally figured out why that particular test is failing. It's not about this PR it's about travis-ci installing the new In
While in
I can update the test notebook to be compatible with ipython 7 and pin the ipython used in testing to be |
Ok, I decided to not pin the I ran the tests on master locally and they are failing because of this same reason so i bet if they get executed right now on travis it will fail but this will fix it. |
Awesome. Thanks for looking into the test failure as well! |
Since the
highlight_code
filter is created on the exporterfrom_notebook_node
function it cannot be overwritten by thefilters
trait.This makes it possible to overwrite it.