DOC: Add missing language specification to code-block #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've created an issue about the Sphinx warning vs. error situation: sphinx-doc/sphinx#5407. |
|
That's surprising! I thought code-block had a default syntax-highlighting language if not specified for a given directive, or at least fallback on no highlighting. |
|
@minrk Thanks for merging! And yes, it is strange, see sphinx-doc/sphinx#5407 and sphinx-doc/sphinx#1851. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-code-block
I'm actually wondering why this is only a Sphinx warning (rather than an error), because it seems to silently remove the code block from the resulting page: https://nbconvert.readthedocs.io/en/5.4/changelog.html#raw-templates