Check for too recent of pandoc version #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfuhruhurr
changed the title
|
My local tests were failing because my version of pandoc was too recent (2.2.1). Using 1.19.1 locally was met with success. The PR now incorporates logic to notify a user of an unsupported version of pandoc (if it's 2.0.0 or newer). This logic won't cause a failure; it will simply inform the user an unsupported version of pandoc is being used. |
ivanov
approved these changes
May 16, 2018
| @@ -1,3 +1,6 @@ | |||
| # trivial line added to run travis on this file | |||
| # because, locally, 2 of the 9 tests fail | |||
|
Thanks for your contribution @hfuhrhurr ! Merging. |
|
Btw just as a heads up, this broke our docs by introducing an API incompatibility ( |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In researching how I can contribute to #610 at the PyCon Sprints, I noticed 2 of the 9 tests in unmodified
test_markdown.pyfailed.@ivanov suggested I make a trivial change and submit a PR so the code would run through Travis to see if the failures are replicated.