Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mathjax tests for markdown are messy and complicated, could be improved #610

Open
mpacer opened this issue Jun 23, 2017 · 4 comments
Open
Labels
good first issue great for new contributors

Comments

@mpacer
Copy link
Member

mpacer commented Jun 23, 2017

We should be able to make that set of tests much nicer.

For example, the test_markdown2html_math_mixed is dependent on whether there is a space after the final period or not, which is an issue with checking for whether content is "in" the resulting html, and the html paragraph tag closes before a new line if there is such a space.

I don't know a generally good approach to this. Maybe it must be messy but that sort of finicky-ness seems undesirable.

@mpacer
Copy link
Member Author

mpacer commented Jun 23, 2017

Note: our current approach to parsing text allows us to treat everything as inline text, which seems bizarre, but – technically – less complicated!

https://github.com/mpacer/nbconvert/tree/mjax_all_inline

I don't know why this is possible. But I think it points toward problems with our current mathjax handling.

@mpacer
Copy link
Member Author

mpacer commented Sep 13, 2017

note with #611 all the logic is now inline.

@pxhanus Are you interested in tackling this?

@mpacer mpacer added the good first issue great for new contributors label Sep 13, 2017
@jzf2101
Copy link

jzf2101 commented Sep 28, 2017

@mpacer could we add this to our list of issues for hacktoberfest?

@jzf2101
Copy link

jzf2101 commented Nov 20, 2017

@fenwickipedia also could be interesting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue great for new contributors
Projects
None yet
Development

No branches or pull requests

2 participants