Make the slide exporter a little more configurable #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuvipanda
commented
Mar 5, 2017
yuvipanda
commented
- Allow configuring which theme to use for reveal.js
- Allow configuring where to load jQuery / require_js / font-awesome from (same reason as Allow customization of URL used to load mathjax #315)
- Move default for loading font-awesome to cdnjs to match default for other URLs
Some installations (such as Wikimedia) prohibit usage of external CDNs for privacy reasons, and this allows them to continue using nbconvert. I also got font-awesome from cdnjs as well, since that's where the other defaults were pointing to.
|
This lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.