Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slides broken in master, defaults values are empty #557

Closed
damianavila opened this issue Mar 26, 2017 · 0 comments
Closed

Slides broken in master, defaults values are empty #557

damianavila opened this issue Mar 26, 2017 · 0 comments
Labels
format:Slides pertains to exporting to the Slides format

Comments

@damianavila
Copy link
Member

damianavila commented Mar 26, 2017

Trying to use slides from master gives me a blank page.
This is cause by empty values for the recently added config options at #542

$ jupyter nbconvert lecture_1.ipynb --to slides --post serve
[NbConvertApp] Converting notebook lecture_1.ipynb to slides
Python 3.6.0 |Continuum Analytics, Inc.| (default, Dec 23 2016, 12:22:00)
Type "copyright", "credits" or "license" for more information.

IPython 5.3.0 -- An enhanced Interactive Python.
?         -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help      -> Python's own help system.
object?   -> Details about 'object', use 'object??' for extra details.

In [1]: resources
Out[1]:
ResourcesDict(None,
              {'config_dir': '/home/damian/.jupyter',
               'metadata': ResourcesDict(None,
                             {'modified_date': 'March 25, 2017',
                              'name': 'lecture_1',
                              'path': ''}),
               'output_extension': '.slides.html',
               'output_files_dir': 'lecture_1_files',
               'reveal': {'font_awesome_url': '',
                'jquery_url': '',
                'require_js_url': '',
                'theme': '',
                'url_prefix': 'reveal.js'},
               'unique_key': 'lecture_1'})

It seems putting the default value inside the traitlets object is not working... and looking into the traitlets docs, I do not see an option to pass a key:value thing where key is default.

I push the following PR: #558, which is adding the default value a the first parameter to pass and everything seems to be OK now.

@mpacer @takluyver @yuvipanda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format:Slides pertains to exporting to the Slides format
Projects
None yet
Development

No branches or pull requests

1 participant