Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing the shell for the action #549

Merged
merged 1 commit into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/actions/check-release/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,14 @@ inputs:
steps_to_skip:
description: "Comma separated list of steps to skip"
required: false
shell:
description: "The shell being used for the action steps"
required: false
default: bash -eux {0}
runs:
using: "composite"
steps:
- shell: bash -eux {0}
- shell: ${{ inputs.shell }}
id: install-releaser
run: |
# Install Jupyter Releaser from git unless we are testing Releaser itself
Expand All @@ -24,7 +28,7 @@ runs:
fi

- id: prep-release
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
export RH_DRY_RUN="true"
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
Expand All @@ -33,7 +37,7 @@ runs:
python -m jupyter_releaser.actions.prep_release

- id: populate-release
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
export RH_DRY_RUN="true"
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
Expand All @@ -43,7 +47,7 @@ runs:
python -m jupyter_releaser.actions.populate_release

- id: finalize-release
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
export RH_DRY_RUN="true"
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
Expand Down
12 changes: 8 additions & 4 deletions .github/actions/finalize-release/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ inputs:
steps_to_skip:
description: "Comma separated list of steps to skip"
required: false
shell:
description: "The shell being used for the action steps"
required: false
default: bash -eux {0}

outputs:
release_url:
Expand All @@ -33,7 +37,7 @@ runs:
using: "composite"
steps:
- name: install-releaser
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
# Install Jupyter Releaser from git unless we are testing Releaser itself
if ! command -v jupyter-releaser &> /dev/null
Expand All @@ -42,7 +46,7 @@ runs:
fi

- id: finalize-release
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
export GITHUB_ACTOR=${{ github.triggering_actor }}
Expand All @@ -54,7 +58,7 @@ runs:
python -m jupyter_releaser.actions.finalize_release

- if: ${{ success() }}
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
echo "## Next Step" >> $GITHUB_STEP_SUMMARY
echo "Verify the final release" >> $GITHUB_STEP_SUMMARY
Expand All @@ -67,7 +71,7 @@ runs:
fi

- if: ${{ failure() }}
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
echo "## Failure Message" >> $GITHUB_STEP_SUMMARY
echo ":x: Failed to Publish the Draft Release Url:" >> $GITHUB_STEP_SUMMARY
Expand Down
10 changes: 7 additions & 3 deletions .github/actions/populate-release/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ inputs:
steps_to_skip:
description: "Comma separated list of steps to skip"
required: false
shell:
description: "The shell being used for the action steps"
required: false
default: bash -eux {0}

outputs:
release_url:
Expand All @@ -30,7 +34,7 @@ runs:
using: "composite"
steps:
- name: install-releaser
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
# Install Jupyter Releaser from git unless we are testing Releaser itself
if ! command -v jupyter-releaser &> /dev/null
Expand All @@ -39,7 +43,7 @@ runs:
fi

- id: populate-release
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
export GITHUB_ACTOR=${{ github.triggering_actor }}
Expand All @@ -51,7 +55,7 @@ runs:
python -m jupyter_releaser.actions.populate_release

- if: ${{ failure() }}
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
echo "## Failure Message" >> $GITHUB_STEP_SUMMARY
echo ":x: Failed to Publish the Draft Release Url:" >> $GITHUB_STEP_SUMMARY
Expand Down
10 changes: 7 additions & 3 deletions .github/actions/prep-release/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ inputs:
since_last_stable:
description: "Use PRs with activity since the last stable git tag"
required: false
shell:
description: "The shell being used for the action steps"
required: false
default: bash -eux {0}
outputs:
release_url:
description: "The html URL of the draft GitHub release"
Expand All @@ -39,7 +43,7 @@ runs:
using: "composite"
steps:
- name: install-releaser
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
# Install Jupyter Releaser from git unless we are testing Releaser itself
if ! command -v jupyter-releaser &> /dev/null
Expand All @@ -48,7 +52,7 @@ runs:
fi

- id: prep-release
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
export GITHUB_ACTOR=${{ github.triggering_actor }}
Expand All @@ -65,7 +69,7 @@ runs:

python -m jupyter_releaser.actions.prep_release

- shell: bash -eux {0}
- shell: ${{ inputs.shell }}
run: |
echo "## Next Step" >> $GITHUB_STEP_SUMMARY
echo "(Optional): Review Draft Release: ${{ steps.prep-release.outputs.release_url }}" >> $GITHUB_STEP_SUMMARY
Expand Down
10 changes: 7 additions & 3 deletions .github/actions/publish-changelog/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ inputs:
description: "If set, do not make a PR"
default: "false"
required: false
shell:
description: "The shell being used for the action steps"
required: false
default: bash -eux {0}
outputs:
pr_url:
description: "The html URL of the draft GitHub release"
Expand All @@ -22,7 +26,7 @@ runs:
using: "composite"
steps:
- name: install-releaser
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
# Install Jupyter Releaser from git unless we are testing Releaser itself
if ! command -v jupyter-releaser &> /dev/null
Expand All @@ -31,7 +35,7 @@ runs:
fi

- id: publish-changelog
shell: bash -eux {0}
shell: ${{ inputs.shell }}
run: |
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
export GITHUB_ACTOR=${{ github.triggering_actor }}
Expand All @@ -43,7 +47,7 @@ runs:

python -m jupyter_releaser.actions.publish_changelog

- shell: bash -eux {0}
- shell: ${{ inputs.shell }}
run: |
echo "## Next Step" >> $GITHUB_STEP_SUMMARY
echo "Merge the changelog update PR: ${{ steps.publish-changelog.outputs.pr_url }}" >> $GITHUB_STEP_SUMMARY
Loading