Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing the shell for the action #549

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

martinRenou
Copy link
Contributor

@martinRenou martinRenou commented Jan 23, 2024

Problem

Discovered in voila-dashboards/voici#107

It seems that when using a mamba-installed yarn (v3) it is not being picked up by the releaser. I understand the issue has to do with the shell being used in the jupyter-releaser action, so making this one configurable could allow to fix it

@blink1073 blink1073 added the enhancement New feature or request label Jan 24, 2024
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit c7d48e9 into jupyter-server:main Jan 24, 2024
19 of 21 checks passed
@martinRenou martinRenou deleted the shell_input branch January 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants