Get jdk-9 back to build JUnit 5 #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Direct Travis build script to install JDK-9 (9b162 as of this commit) and set `JDK_JAVA_OPTIONS` that allow Gradle to run on Java 9.
There is a regression in JDK-9 b162 that leads to an exception: "Cannot create Launcher for multiple engines with the same ID 'xyz'". See https://bugs.openjdk.java.net/browse/JDK-8177139 for details This commit can be reverted when Travis CI installs a JDK-9 b163 or higher.
sormuras
force-pushed
the
issues/775-compile-and-test-on-jdk9
branch
from
dc89ff3 to
7ac845f
Compare
This reverts the test engine pruning needed by the old jdk-9 b162
sormuras
force-pushed
the
issues/775-compile-and-test-on-jdk9
branch
from
7ac845f to
d0443a3
Compare
marcphilipp
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Current state of getting jdk-9 back to build JUnit 5 - not only on Travis CI.
With 4e401dd the
'-Werror'compiler option is untouched, i.e. remains activated.Fixes #775
Note
Travis CI (debian trusty) is still on JDK9-B162, due to webupd8team is on 162.
Using a manually installed JDK9-B168 with d0443a3 for now.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations