Compile and test on Java 9 #775

sormuras · 2017-04-06T16:43:33Z

Moved "Lessons learned..." to Wiki

Lessons learned "JUnit 5 compile and test on Java 9 b162"

Here, only the remaining technical steps resulting from the lessons learned are retained.

Related Issues

Test against JDK 9 modules #425 "Test against JDK 9 modules"
Compile and test on Java 12 #1951 "Java 12"

Deliverables

Upgrade to Gradle 3.5 - done in master with 5ef538f
Add information tag stating location from where an engine was loaded from - see Add ClassLoaderUtils and log location from which an engine was loaded #788
Merge main Java 8 and this Java 9 build into a single .travis.yml script -- via a313a07
Include AssertJ 3.7.0 - remove jitpack from repositories
Include Gradle Shadow 2.0.0 - remove jfrog.org/artifactory from repositories
~~Report and~~ remove workaround for ServiceLoader "bug" when "everybody" has access to build 163

The text was updated successfully, but these errors were encountered:

jbduncan · 2017-04-06T17:50:06Z

I'm curious as to why build warnings should not be treated as errors.

How long should they not be treated as errors, if it's just a temporary measure?

sormuras · 2017-04-06T18:08:37Z

It's just a temporary measure to not break the build at https://travis-ci.org/junit-team/junit5/builds/219251561#L752 ... which should use AccessibleObject.canAccess as soon as we switch to Java 9.

sbrannen · 2017-04-06T20:03:32Z

@sormuras, thanks for compiling all of this information! 👍

sbrannen · 2017-04-06T20:09:33Z

FYI: the Shadow plugin has already been upgraded to ASM 5.2: GradleUp/shadow#285

sbrannen · 2017-04-06T20:20:27Z

Why not just suppress deprecation warnings on the call for now?

Or... would that mess up the JDK 8 build? 😜

sbrannen · 2017-04-06T20:21:21Z

It'll also be nice to be able to switch to trySetAccessible(), but we'll have to wait until JUnit 6 for that probably.

jbduncan · 2017-04-06T20:27:30Z

Alternatively to waiting for JUnit 6, we might be able to use MR-JAR support coming with Java 9, once we have a clear picture of how MR-JARs fit into Gradle. :)

sbrannen · 2017-04-06T21:27:27Z

Alternatively to waiting for JUnit 6, we might be able to use MR-JAR support coming with Java 9, once we have a clear picture of how MR-JARs fit into Gradle. :)

Ummmm... yeah... once we can actually (reliably) develop against Java 9 with the whole tool chain (Gradle, all CI servers, IDEs, etc.). So, I'm not going to hold my breath for that at the moment.

jbduncan · 2017-04-06T21:43:05Z

Of course.

reinhapa · 2017-04-06T21:44:21Z

I would be happy to help on that as soon you wanted to start on this issue...

sormuras · 2017-04-07T11:06:57Z

http://mailman.qos.ch/pipermail/announce/2017/000146.html

Ceki just released SLF4J version 1.8.0-alpha0, modularized for Java9/Jigsaw/JPMS/JSR 376, on Maven Central. Let's have look how he did.

This commit removes failing jdk-9 build and caching. * Java 9 will be re-installed by #775. * Caching gradle and dependency binaries did not result in build speed-ups and the applied "--refresh-dependencies" did by-pass the cache anyway.

sormuras · 2017-04-10T09:20:34Z

W/ daemon (default): https://travis-ci.org/junit-team/junit5/builds/220482687 works
W/o daemon (--no-daemon): https://travis-ci.org/junit-team/junit5/builds/220480116 fails

Why?

This commit removes failing jdk-9 build and caching. * Java 9 will be re-installed by #775. * Caching gradle and dependency binaries did not result in build speed-ups and the applied "--refresh-dependencies" did by-pass the cache anyway.

Upgrade to AssertJ 3.7.0-SNAPSHOT (using jitpack) Use JDK_JAVA_OPTIONS to open java.base and other packages ServiceLoader.load() loads providers multiple times - prune 'em Addresses: #775

sormuras · 2017-05-04T07:04:19Z

All three open ends are still not resolvable:

Travis CI (debian trusty) is still on JDK9-B162, see https://launchpad.net/~webupd8team/+archive/ubuntu/java?field.series_filter=trusty
@johnrengelman did not release Gradle Shadow 2.0.0 yet, see https://github.com/johnrengelman/shadow/releases
@joel-costigliola did not release AssertJ 3.7.0 yet, set https://github.com/joel-costigliola/assertj-core/releases

joel-costigliola · 2017-05-04T07:55:56Z

@sormuras AssertJ 3.7.0 should be released in a week or so.

sormuras · 2017-05-04T07:56:58Z

Thanks for the information, Joel! 👍

Upgrade to AssertJ 3.7.0 Use JDK_JAVA_OPTIONS to open java.base and other packages ServiceLoader.load() loads providers multiple times - prune 'em Addresses: #775

sormuras · 2017-05-07T17:24:58Z

AssertJ 3.7.0 now used in master via 30581c7

marcphilipp · 2017-05-07T17:28:29Z

@johnrengelman Are there any updates regarding Shadow 2.0.0?

johnrengelman · 2017-05-09T14:44:19Z

@marcphilipp I'm going to publish it tonight when I get home.

Addresses #775

sormuras · 2017-05-10T05:04:21Z

Shadow 2.0.0 now used in master via febcfe9

sormuras added theme: build type: task labels Apr 6, 2017

sormuras added this to the 5.0 M5 milestone Apr 6, 2017

sormuras mentioned this issue Apr 6, 2017

Test against JDK 9 modules #425

Closed

8 tasks

sormuras self-assigned this Apr 7, 2017

sormuras changed the title ~~Lessons learned "JUnit 5 - compile and test on Java 9"~~ Compile and test on Java 9 Apr 8, 2017

sormuras added the theme: modules label Apr 8, 2017

sormuras mentioned this issue Apr 10, 2017

Add ClassLoaderUtils and log location from which an engine was loaded #788

Closed

marcphilipp modified the milestones: 5.0 M5, 5.0 M6 May 6, 2017

marcphilipp added the status: triaged label May 6, 2017

sormuras added a commit that referenced this issue May 7, 2017

Get jdk-9 back to build JUnit 5 on Travis

bc9d669

Upgrade to AssertJ 3.7.0 Use JDK_JAVA_OPTIONS to open java.base and other packages ServiceLoader.load() loads providers multiple times - prune 'em Addresses: #775

sormuras pushed a commit that referenced this issue May 7, 2017

update assertj to 3.7.0 for java 9 compatibility (#775)

30581c7

sormuras mentioned this issue May 7, 2017

Get jdk-9 back to build JUnit 5 #842

Merged

4 tasks

sormuras added a commit that referenced this issue May 10, 2017

Upgrade Shadow (Gradle plugin) to version 2.0.0

febcfe9

Addresses #775

sormuras closed this as completed in #842 May 15, 2017

sormuras modified the milestones: 5.0 M5, 5.0 M6 May 15, 2017

sormuras removed status: triaged type: task labels May 15, 2017

sormuras mentioned this issue Jul 9, 2019

Compile and test on Java 12 #1951

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compile and test on Java 9 #775

Compile and test on Java 9 #775

sormuras commented Apr 6, 2017 •

edited

Loading

jbduncan commented Apr 6, 2017

sormuras commented Apr 6, 2017 •

edited

Loading

sbrannen commented Apr 6, 2017

sbrannen commented Apr 6, 2017

sbrannen commented Apr 6, 2017

sbrannen commented Apr 6, 2017

jbduncan commented Apr 6, 2017

sbrannen commented Apr 6, 2017 •

edited

Loading

jbduncan commented Apr 6, 2017

reinhapa commented Apr 6, 2017

sormuras commented Apr 7, 2017 •

edited

Loading

sormuras commented Apr 10, 2017 •

edited

Loading

sormuras commented May 4, 2017 •

edited

Loading

joel-costigliola commented May 4, 2017

sormuras commented May 4, 2017

sormuras commented May 7, 2017

marcphilipp commented May 7, 2017

johnrengelman commented May 9, 2017

sormuras commented May 10, 2017

Compile and test on Java 9 #775

Compile and test on Java 9 #775

Comments

sormuras commented Apr 6, 2017 • edited Loading

Moved "Lessons learned..." to Wiki

Related Issues

Deliverables

jbduncan commented Apr 6, 2017

sormuras commented Apr 6, 2017 • edited Loading

sbrannen commented Apr 6, 2017

sbrannen commented Apr 6, 2017

sbrannen commented Apr 6, 2017

sbrannen commented Apr 6, 2017

jbduncan commented Apr 6, 2017

sbrannen commented Apr 6, 2017 • edited Loading

jbduncan commented Apr 6, 2017

reinhapa commented Apr 6, 2017

sormuras commented Apr 7, 2017 • edited Loading

sormuras commented Apr 10, 2017 • edited Loading

sormuras commented May 4, 2017 • edited Loading

joel-costigliola commented May 4, 2017

sormuras commented May 4, 2017

sormuras commented May 7, 2017

marcphilipp commented May 7, 2017

johnrengelman commented May 9, 2017

sormuras commented May 10, 2017

sormuras commented Apr 6, 2017 •

edited

Loading

sormuras commented Apr 6, 2017 •

edited

Loading

sbrannen commented Apr 6, 2017 •

edited

Loading

sormuras commented Apr 7, 2017 •

edited

Loading

sormuras commented Apr 10, 2017 •

edited

Loading

sormuras commented May 4, 2017 •

edited

Loading