Update to slic d77d6e8 #2450
Merged
Update to slic d77d6e8 #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1308
In previous version of submodule
slic, there was invalid access to element of minus index ofstd::vector.This caused segmentation fault in
jsk_perception/slic_super_pixelsnode during destructor of that vector was called.Probably this is why
slic_super_pixelsfails when large image is used (reported in #1308 ).I updated
slicto the latest commit and confirmed it works with large image.i.e.
jsk_perception/sample/kiva_pod_image_color.jpg(size is 1920 x 1080)Thanks @pazeshun