Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes scope bug on point_pose_extraction #2414

Merged
merged 3 commits into from
Jun 26, 2019

Conversation

furushchev
Copy link
Member

@furushchev furushchev commented Mar 14, 2019

This PR fixes some bugs on point_pose_extraction node.
Since the ObjectDetection_agg topic here was just an alias of ObjectDetection and it was not aggregated, I created an aggregator. (see jsk-ros-pkg/jsk_common_msgs#24 )

Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you intend to use this node with jsk-ros-pkg/jsk_common_msgs#24, plese update the https://github.com/jsk-ros-pkg/jsk_recognition/blob/master/jsk_perception/launch/point_pose_extractor_sample.launch

but to keep backward compatibility and avoid confusion, another solution is to publish _agg from this node with more slower rate. Not sure which is better.

@YutoUchimi
Copy link
Contributor

For backward compatibility, I reverted the commit in which publishing of ObjectDetection_agg is removed.
If we need slower rate for _agg, let's make another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants