Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crls.js.org #7784

Merged
merged 1 commit into from
Nov 8, 2022
Merged

crls.js.org #7784

merged 1 commit into from
Nov 8, 2022

Conversation

lukecarr
Copy link
Contributor

@lukecarr lukecarr commented Nov 6, 2022

MattIPv4
MattIPv4 approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/lukecarr/crls/tree/gh-pages

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Nov 6, 2022
@indus indus added the 404 The page requested returns a 404 response label Nov 7, 2022
@indus
Copy link
Member

indus commented Nov 7, 2022

I've already added your requested subdomain to JS.ORGs zonefile. But I'm getting a 404 error from Github. It looks like you are using a workflow to deploy. This is most likely the reason for the problem. You have to fix this on your own. Maybe this is helpful to you: #7666 (comment)
I'll merge after we have "contact". Please keep this PR open.

@lukecarr
Copy link
Contributor Author

lukecarr commented Nov 7, 2022

Should be all sorted now. working on my end after a quick bump to force a new deployment!

@indus indus removed the 404 The page requested returns a 404 response label Nov 8, 2022
@indus
Copy link
Member

indus commented Nov 8, 2022

Welcome https://crls.js.org

@indus indus merged commit 34fcbd0 into js-org:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukecarr @indus @MattIPv4