-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guildedbot.js.org #7666
guildedbot.js.org #7666
Conversation
MDCYT
commented
Oct 1, 2022
- I have read and accepted the Terms and Conditions
- There is reasonable content on the page
- I have added a CNAME file to my repo: Guilded Bot Docs
- [x] I have read and accepted the [Terms and Conditions](http://js.org/terms.html) - [x] There is reasonable content on the page - [x] I have added a CNAME file to my repo: ***[Guilded Bot Docs](https://mdcyt.github.io/Guilded-Bot-Docs/)***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there!
❌ Before we can accept your domain request, you need to create a file named CNAME
in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance guildedbot.js.org
.
Hm, it doesn't look like GitHub has detected it, mdcyt.github.io/Guilded-Bot-Docs isn't redirecting as I'd expect. Could you check your GitHub Pages settings for the repo to see if the custom subdomain has been detected? |
I've already added your requested subdomain to JS.ORGs zonefile. But I'm getting a redirect error. It looks like you are using a workflow to deploy. This is most likely the reason for the problem. You have to fix this on your own. |
Welcome https://guildedbot.js.org P.S.: In case you know what did make it work in the end, it would be nice if you could tell me so I can give it as a hint to future requesters that use a workflow setup. |
First I did without workflow, I made a default Github Pages page come up and set the Custom Domain and CNAME at the same time, and after that, seeing that it works, saying to use a workflow and it worked. And about 2 questions if there is no bother. Can I PR for an additional domain ("guide.guildedbot.js.org") and can I move the repositories from my account to an organization without any problems? |
Thanks for the details.Regarding your questions - You can request another subdomain, but not for the same repo (that is Github Pages limitation as there can only be one CNAME). For sub-subdomains we can't provide SSL on our side but you can just enable it in the repo settings.To move the repo to an organisation you should open a PR to make a change in the list as well. GitHub may redirect internally when ownership changes but it is good to keep the list in sync.
|