Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guildedbot.js.org #7666

Merged
merged 2 commits into from
Oct 1, 2022
Merged

guildedbot.js.org #7666

merged 2 commits into from
Oct 1, 2022

Conversation

MDCYT
Copy link
Contributor

@MDCYT MDCYT commented Oct 1, 2022

- [x] I have read and accepted the [Terms and Conditions](http://js.org/terms.html)
- [x] There is reasonable content on the page
- [x] I have added a CNAME file to my repo: ***[Guilded Bot Docs](https://mdcyt.github.io/Guilded-Bot-Docs/)***
@MattIPv4 MattIPv4 changed the title Update cnames_active.js guildedbot.js.org Oct 1, 2022
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance guildedbot.js.org.

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Oct 1, 2022
@MDCYT
Copy link
Contributor Author

MDCYT commented Oct 1, 2022

Hello.

Done, sorry for forgetting to add the CNAME

image

@MDCYT MDCYT requested a review from MattIPv4 October 1, 2022 02:59
@MattIPv4
Copy link
Member

MattIPv4 commented Oct 1, 2022

Hm, it doesn't look like GitHub has detected it, mdcyt.github.io/Guilded-Bot-Docs isn't redirecting as I'd expect. Could you check your GitHub Pages settings for the repo to see if the custom subdomain has been detected?

@MDCYT
Copy link
Contributor Author

MDCYT commented Oct 1, 2022

I think it was not detected, I just set it manually.

image

@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account error The page requested returns an error and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Oct 1, 2022
@indus
Copy link
Member

indus commented Oct 1, 2022

I've already added your requested subdomain to JS.ORGs zonefile. But I'm getting a redirect error. It looks like you are using a workflow to deploy. This is most likely the reason for the problem. You have to fix this on your own.
I'll merge after we have "contact". Please keep this PR open.

@MDCYT
Copy link
Contributor Author

MDCYT commented Oct 1, 2022

Ready, after a few attempts, I think it was successful.

image

@indus
Copy link
Member

indus commented Oct 1, 2022

Welcome https://guildedbot.js.org

P.S.: In case you know what did make it work in the end, it would be nice if you could tell me so I can give it as a hint to future requesters that use a workflow setup.

@indus indus merged commit b9a10b1 into js-org:master Oct 1, 2022
@MDCYT
Copy link
Contributor Author

MDCYT commented Oct 2, 2022

First I did without workflow, I made a default Github Pages page come up and set the Custom Domain and CNAME at the same time, and after that, seeing that it works, saying to use a workflow and it worked.

And about 2 questions if there is no bother.

Can I PR for an additional domain ("guide.guildedbot.js.org") and can I move the repositories from my account to an organization without any problems?

@indus
Copy link
Member

indus commented Oct 2, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain error The page requested returns an error project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants