Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redux-toolkit.js.org #3534

Merged
merged 2 commits into from
Nov 13, 2019
Merged

redux-toolkit.js.org #3534

merged 2 commits into from
Nov 13, 2019

Conversation

markerikson
Copy link
Contributor

Adding a second DNS name to point to the Redux Starter Kit docs as part of our package rename, per #3532 .

@markerikson
Add additional alias for Redux Starter Kit rename
4409702 
As part of renaming Redux Starter Kit to Redux Toolkit, we'd like to have both old and new hostnames pointing to our docs site.
@markerikson
Fix typo
373aeac
@indus indus changed the title Add additional alias for Redux Starter Kit rename redux-toolkit.js.org Nov 12, 2019
@indus indus added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages 404 The page requested returns a 404 response awaiting response This PR is waiting for a response from the requester labels Nov 12, 2019
@indus
Copy link
Member

indus commented Nov 12, 2019 •
edited
Loading

@markerikson The new CNAME record is in place. Could you give me a hint when the this subdomain is working so I can merge.

I'm not sure netlify supports multiple CNAMES for the same target. In case it works we could keep both subdomains in JS.ORGs zonefile. If not you may want to point the old one to page that redirects to the new page. But if the old subdomain becomes completly abandoned I would like to remove it frome the zonefile.
#3532 (comment)

@markerikson
Copy link
Contributor Author

I've just added redux-toolkit.js.org as an additional DNS alias in the Netlify control panel. I think that may be all that's needed on my end.

And yes! In fact, https://redux-toolkit.js.org/ correctly hits the RSK docs site right now!

@indus indus removed 404 The page requested returns a 404 response awaiting response This PR is waiting for a response from the requester labels Nov 13, 2019
@indus
Copy link
Member

indus commented Nov 13, 2019

Welcome https://redux-toolkit.js.org

@indus indus merged commit 8bdcc85 into js-org:master Nov 13, 2019
@MattIPv4 MattIPv4 mentioned this pull request Sep 24, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markerikson @indus