Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming package rename: Redux Starter Kit -> Redux Toolkit #3532

Closed
markerikson opened this issue Nov 12, 2019 · 8 comments
Closed

Upcoming package rename: Redux Starter Kit -> Redux Toolkit #3532

markerikson opened this issue Nov 12, 2019 · 8 comments

Comments

@markerikson
Copy link
Contributor

markerikson commented Nov 12, 2019

We are planning to rename our Redux Starter Kit package (redux-starter-kit) to Redux Toolkit (@reduxjs/toolkit), per reduxjs/redux-toolkit#246. Our docs are currently hosted at https://redux-starter-kit.js.org , and I would like to change that to https://redux-toolkit.js.org when we're ready to flip the switch. Ideally, I'd also like to redirect any future requests of redux-starter-kit.js.org to redux-toolkit.js.org, permanently.

What steps will I need to take to make that happen?

@MattIPv4
Copy link
Member

In terms of actually changing the domain, you'll just want to open a PR that updates your entry in the cnames_active.js file.

As for a redirect, you will want to set up a page like https://node.js.org/ that contains a redirect triggered by a user action. We don't permit automatic redirects.

@indus
Copy link
Member

indus commented Nov 12, 2019

@markerikson We can of course set up the new CNAME in JS.ORGs zonefile before you actually do the change in the repo to keep interrupts to a minimum. And if you want you even could keep both the subdomains.

@markerikson
Copy link
Contributor Author

Yeah, if we could actually keep both domain names and point them both at the same site, that would be ideal. Can we do that?

@MattIPv4
Copy link
Member

GitHub pages only lets you have one CNAME record per site.

@markerikson
Copy link
Contributor Author

We're on Netlify, not GH Pages.

@markerikson
Copy link
Contributor Author

For reference, the site we're pointing to is redux-starter-kit-docs.netlify.com:

"redux-starter-kit": "redux-starter-kit-docs.netlify.com",

@MattIPv4
Copy link
Member

Ah right, my bad, not too familiar with netlify, does it look like you could setup two custom names for the same site?

@markerikson
Copy link
Contributor Author

Seems like it, yes:

https://twitter.com/kylemh_/status/1194327997546811392

@markerikson markerikson mentioned this issue Nov 12, 2019
2 tasks
@indus indus closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants