Add Scala frontend #570
Merged
Add Scala frontend #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pom.xml
# Conflicts: # README.md # jplag/pom.xml # jplag/src/main/java/de/jplag/options/LanguageOption.java # pom.xml
tsaglam
added
enhancement
dfuchss
reviewed
Aug 6, 2022
jplag.frontend.scala/src/test/java/de/jplag/scala/ScalaFrontendTest.java
Outdated
Show resolved
Hide resolved
|
It turns out the IDE settings kept me from successfully upgrading to Scala 2.13, which I now succeeded in doing. Scalameta, the parser library used here, is in development for Scala 3, but not released yet, so it seems that we have to wait for that until Scala 3 can be fully supported. |
sebinside
reviewed
Aug 8, 2022
jplag.frontend.scala/src/main/scala/de/jplag/scala/ScalaToken.scala
Outdated
Show resolved
Hide resolved
SuyDesignz
reviewed
Aug 8, 2022
jplag.frontend.scala/src/main/scala/de/jplag/scala/Language.scala
Outdated
Show resolved
Hide resolved
jplag.frontend.scala/src/test/java/de/jplag/scala/ScalaFrontendTest.java
Outdated
Show resolved
Hide resolved
…bbreviated identifiers
|
Kudos, SonarCloud Quality Gate passed! |
tsaglam
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Scala frontend to JPlag. It comes with some test files and a README which explains various design choices that can be considered for maintenance.
The frontend only supports Scala 2.12 so far. Maybe it can be upgraded to Scala 3 easily in a collective effort, I certainly failed to do it! In that case, a few more token types might be necessary.
Besides the difficulties with the syntax discussed in the README, the token set and the abstraction are designed along the lines of other frontends.
As the parser takes a different approach that reduces code repetition, it should be considered if the parser mechanism is redesigned in the future.
Addressing #345, #568