Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge additional frontends from (semi-) active forks #202

Closed
tsaglam opened this issue Oct 21, 2021 · 5 comments
Closed

Merge additional frontends from (semi-) active forks #202

tsaglam opened this issue Oct 21, 2021 · 5 comments
Labels
enhancement Issue/PR that involves features, improvements and other changes good first issue Good first issue for new contributors. New contributors are welcome! language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change

Comments

@tsaglam
Copy link
Member

tsaglam commented Oct 21, 2021 •
edited
Loading

We could merge some existing frontends to offer support for more languages. Candidates are the Scala frontend, the R frontend, and the Jupyter Notebook frontend from @CodeGra-de. The frontends would probably require a bit of cleanup and some minor changes need to be made to adapt them to recent changes of the frontend utils.
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag good first issue Good first issue for new contributors. New contributors are welcome! labels Oct 21, 2021
@tsaglam
Copy link
Member Author

tsaglam commented Nov 26, 2021

#56 also offers an R frontend, however, it currently cannot be merged due to conflicts.

@tsaglam

This comment was marked as off-topic.

Sign in to view
@tsaglam tsaglam mentioned this issue Apr 4, 2022
Closed
5 tasks
@libre-man
Copy link

What we (CodeGrade) did in our fork is that we made it possible to use external processes to parse the languages. The major advantage is that you can use existing parsers from the language itself, this makes creating (and updating) parsers way easier. We are still in the process of optimising that, but if you want we can send a PR when we have finalised that.

@tsaglam
Copy link
Member Author

tsaglam commented Apr 4, 2022 •
edited
Loading

@libre-man sounds interesting, I might have a look at it if I find some time. Do you have a link for me as a reference point?

@tsaglam
Copy link
Member Author

tsaglam commented Sep 15, 2022

Closed, as the viable language modules were adopted and merged in #570 and #455.

@tsaglam tsaglam closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes good first issue Good first issue for new contributors. New contributors are welcome! language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsaglam @libre-man