Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bc prs #434

Merged
merged 10 commits into from
Jan 27, 2025
Merged

Bc prs #434

merged 10 commits into from
Jan 27, 2025

Conversation

jopeek
Copy link
Owner

@jopeek jopeek commented Jan 20, 2025 •
edited
Loading

costonb and others added 7 commits January 18, 2025 21:41
@costonb
Update moveItem logic to merge item with existing if the character al…
75b7536 
…ready has a stack
@costonb
fix plus minus item quantity permissions
f24da23 
Wrap them in if root owner tags
@costonb
Add in ability to split coins
de0f6de 
Moved distributeCoins to static method in helper so both code paths went through the same code
Made adjustments to the distributeCoins method so it works properly
Added button to split coins
Added owner check for the manage currency button
@jopeek
Merge pull request #431 from costonb/item-merge
20162d8 
merge stacks on loot/buy item
@jopeek
Merge pull request #432 from costonb/item-quantity-permissions
3176599 
fix plus minus item quantity permissions
@jopeek
Merge branch 'bc-prs' into split-currency
589fbcf
@jopeek
Merge pull request #433 from costonb/split-currency
49c86cd 
Add ability to split coins
@costonb
Copy link
Contributor

costonb commented Jan 20, 2025

Cool. We've been using this module for a while in our games, but I had a fork with several changes. The past couple times there's been a major upgrade there's been quite a few merge conflicts, so i figured I'd just submit some PRs.

I do have two more I plan to open. One for simplifying how the tabs are done. They provide a static method that can be overridden for that rather than the html manipulation that's happening now. The other is adding a tab to sell items to the merchant. That one was working well when you were manually doing the _prepareItems() logic, but now that you're just using the super class code I'm having to re-work quite a bit for the player's inventory. The tab PR I'll open here in the next couple hours, I'll use this branch as the base. The selling PR will probably not be this week since I mostly only have time and energy to work on this on my days off work.

costonb and others added 3 commits January 20, 2025 12:36
@costonb
Use TABS static variable
78dfd07 
Simplify module to override the TABS static variable rather than adjusting html directly in activateListensers method
@jopeek
Merge pull request #435 from costonb/simplify-tabs
e7cb82d 
Use TABS static variable
@jopeek
Update module.json
220a0a3
@jopeek jopeek merged commit 4400f9b into lootsheet-simple Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jopeek @costonb