Add ability to split coins #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved distributeCoins to static method in helper so both code paths went through the same code Made adjustments to the distributeCoins method so it works properly Added button to split coins Added owner check for the manage currency button
|
I'll review this and the others sometime this week. Thanks for the
contributions!
…On Sun, Jan 19, 2025 at 2:42 AM Brandon Coston ***@***.***> wrote:
Moved distributeCoins to static method in helper so both socket and
non-socket code paths went through the same code
Made adjustments to the distributeCoins method so it works properly with
current version of dnd5e
Added button to split coins
Added owner check for the manage currency button
------------------------------
You can view, comment on, or merge this pull request online at:
#433
Commit Summary
- de0f6de
<de0f6de>
Add in ability to split coins
File Changes
(2 files <https://github.com/jopeek/fvtt-loot-sheet-npc-5e/pull/433/files>
)
- *M* lootsheet-simple.js
<https://github.com/jopeek/fvtt-loot-sheet-npc-5e/pull/433/files#diff-7f8625dbf2cfee7e62d8b044d1183cb8c06d85e0f2b39e1412403f664986c2d3>
(273)
- *M* template/npc-sheet.hbs
<https://github.com/jopeek/fvtt-loot-sheet-npc-5e/pull/433/files#diff-9fc94710e2581a83307bcdc8350e0a790987bcf848835fb1de925ed7305aa405>
(29)
Patch Links:
- https://github.com/jopeek/fvtt-loot-sheet-npc-5e/pull/433.patch
- https://github.com/jopeek/fvtt-loot-sheet-npc-5e/pull/433.diff
—
Reply to this email directly, view it on GitHub
<#433>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJBV6XS5NU5MM2EJGRULI32LN6R5AVCNFSM6AAAAABVOSGGVGVHI2DSMVQWIX3LMV43ASLTON2WKOZSG44TONJVGY3DONQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Jan Ole Peek
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved distributeCoins to static method in helper so both socket and non-socket code paths went through the same code
Made adjustments to the distributeCoins method so it works properly with current version of dnd5e
Added button to split coins
Added owner check for the manage currency button