Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-528: improve JarDetailsOverlay header #588

Conversation

Jared-Dahlke
Copy link
Contributor

@Jared-Dahlke Jared-Dahlke commented Jan 5, 2023

Closes #528

This PR moves the "UTXOS | DETAILS" tab out of the header and places it just below the header instead.

Here is screenshots of the changes:
image
image

I also made sure that all of the other instances of <SegmentedHeader/> still look good:
image
image

@Jared-Dahlke
Copy link
Contributor Author

I just realized this looks weird on mobal mode though:
image

Let me work on this and resubmit.

@Jared-Dahlke
Copy link
Contributor Author

I fixed mobile mode. Reopened

@Jared-Dahlke Jared-Dahlke reopened this Jan 5, 2023
@theborakompanioni theborakompanioni self-requested a review January 9, 2023 12:16
@theborakompanioni theborakompanioni added the UI/UX Issue related to cosmetics, design, or user experience label Jan 9, 2023
Copy link
Collaborator

@theborakompanioni theborakompanioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Jared-Dahlke, thanks so much! Really nice.

Did some small adaptions, mostly simplification of styles.
Your contribution is highly appreciated. Looking forward to the next one 🚀 🚀 🚀

@theborakompanioni theborakompanioni merged commit ccad8e7 into joinmarket-webui:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: improve header of JarDetailsOverlay
2 participants