Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: improve header of JarDetailsOverlay #528

Closed
theborakompanioni opened this issue Oct 3, 2022 · 2 comments · Fixed by #588
Closed

ui: improve header of JarDetailsOverlay #528

theborakompanioni opened this issue Oct 3, 2022 · 2 comments · Fixed by #588
Labels
concept Wild idea, or too many details unknown yet good first issue Good for newcomers UI/UX Issue related to cosmetics, design, or user experience

Comments

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Oct 3, 2022

Header of JarDetailsOverlay component can be visually improved and should be aligned with the Figma copy.
Figma: https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI

📸 Before/Current

📸 After

@theborakompanioni theborakompanioni added good first issue Good for newcomers concept Wild idea, or too many details unknown yet UI/UX Issue related to cosmetics, design, or user experience labels Oct 3, 2022
@Jared-Dahlke
Copy link
Contributor

@theborakompanioni how does this look?

light mode:
image

dark mode:
image

I think the tabs need a new styling for dark mode when they are on the lighter color bg, but I don't see a figma for that. Was thinking about adding a new prop to to accamodate this

@theborakompanioni
Copy link
Collaborator Author

@theborakompanioni how does this look?

Great 🧡

I think the tabs need a new styling for dark mode when they are on the lighter color bg, but I don't see a figma for that. Was thinking about adding a new prop to to accamodate this

Yeah, what about adapting the background color in dark mode e.g. matching the darker color of the table? We can further discuss in the PR. Just try and take what you feel fits best for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept Wild idea, or too many details unknown yet good first issue Good for newcomers UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants