feat: show address reuse warning #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
self-assigned this
I'd vote for disabling. Should we do the same on the Jam page? Currently, only the inputs are checked for duplicates, not, whether the destination is an address in control of Jam as well. |
Co-authored-by: Thebora Kompanioni <[email protected]>
theborakompanioni
approved these changes
Jul 21, 2022
+1 for disabling. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #404.
Warns the user in case a destination address on the Send screen is a known "internal" address that's not labelled as
new.Edit: Currently, we'd not allow sending to that address. Alternatively, we could also just show the warning but allow sending Any preferences @dergigi @theborakompanioni?
📸