Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show address reuse warning #404

Closed
dergigi opened this issue Jul 16, 2022 · 3 comments · Fixed by #411
Closed

Show address reuse warning #404

dergigi opened this issue Jul 16, 2022 · 3 comments · Fixed by #411
Labels
concept Wild idea, or too many details unknown yet

Comments

@dergigi
Copy link
Contributor

dergigi commented Jul 16, 2022

Currently, it is not only possible to reuse addresses in Jam, there is also no indication that there's anything wrong with that. We probably want to, at the very least, show a warning. We should be able to easily do this for all "internal" Jam addresses, i.e. if you accidentally paste the same address twice (e.g. to fund a jar with multiple transactions).

It would also be good to show a warning in general, for any address, but we can't query the backend for that as of now.

We could also think of a "strict" setting that doesn't allow any reuse at all, no matter what.

@dergigi dergigi added the concept Wild idea, or too many details unknown yet label Jul 16, 2022
@dergigi dergigi added this to the v0.0.10 - Jam it in there! milestone Jul 16, 2022
@dergigi dergigi added this to JAM Jul 16, 2022
@MaxHillebrand
Copy link
Contributor

This warning should also be in the receive page.

Warning in the send tab only solves in-wallet self spends, but most cases are when sending from external wallets.

Hiding addresses that have received a coin might be an option.

@ghost
Copy link

ghost commented Jul 20, 2022

This warning should also be in the receive page.

The receive page will only ever show you new addresses. We query the backend for a new address on every render of the page.

@ghost
Copy link

ghost commented Jul 20, 2022

Agreed, we should to show a warning to prevent the address reuse from happening in the first place.

Just to bring it up here: If address reuse happens nonetheless, the backend will automatically freeze the second UTXO and label the address as reused.

@ghost ghost self-assigned this Jul 20, 2022
@ghost ghost moved this to In Progress ⌛ in JAM Jul 20, 2022
@ghost ghost closed this as completed in #411 Jul 21, 2022
Repository owner moved this from In Progress ⌛ to Done ✅ in JAM Jul 21, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept Wild idea, or too many details unknown yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants