Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: skip running pre-push hooks when subprocessing to match git2 behaviour #5612

Merged
merged 1 commit into from
Feb 6, 2025
Merged

git: skip running pre-push hooks when subprocessing to match git2 behaviour #5612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/src/git_subprocess.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,12 @@ impl<'a> GitSubprocessContext<'a> {
) -> Result<(Vec<String>, Vec<String>), GitSubprocessError> {
let mut command = self.create_command();
command.stdout(Stdio::piped());
command.args(["push", "--porcelain"]);
// Currently jj does not support commit hooks, so we prevent git from running
// them
//
// https://github.com/jj-vcs/jj/issues/3577 and https://github.com/jj-vcs/jj/issues/405
// offer more context
command.args(["push", "--porcelain", "--no-verify"]);
if callbacks.progress.is_some() {
command.arg("--progress");
}
Expand Down