git: skip running pre-push hooks when subprocessing to match git2 behaviour #5612
Conversation
bsdinis
force-pushed
the
bsdinis/mzqymxuzlnyz
branch
from
7579c59 to
c098b8a
Compare
bsdinis
force-pushed
the
bsdinis/mzqymxuzlnyz
branch
from
c098b8a to
805c123
Compare
There was a problem hiding this comment.
LGTM, but let's give @arxanas a chance to object before merging.
There was a problem hiding this comment.
To be clear, for this PR, I just wanted to update the comment to specify that it's an intermediate state of indecision rather than the ultimate state, rather than make any specific decision about pre-push hooks right now. It looks good to me now that the comment includes references to the relevant issues.
Oops, sorry about this. I see now that I didn't write what I wanted to write. Originally, I wrote something like "let's update the comment to say that this is not the end goal", but then I realized we technically did not have agreement on whether it was or wasn't the end goal, so I tried to adjust the wording, and did so wrongly. |
This fixes #5610