Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally include Zipkin Docker container #17909

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Conditionally include Zipkin Docker container #17909

merged 4 commits into from
Feb 18, 2022

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Feb 17, 2022

Related to #17615.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima
Copy link
Member

mshima commented Feb 17, 2022

I was about to start this PR 😄.
Missing to update snapshots:

npm run update-snapshot generators/server
npm run update-snapshot test/app.spec.js
npm run update-snapshot test/blueprint

Those should be enough.

@mshima mshima merged commit d17aef2 into main Feb 18, 2022
@mshima mshima deleted the zipkin-docker branch February 18, 2022 03:37
@pascalgrimaud pascalgrimaud added this to the 7.7.0 milestone Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants