-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sleuth/zipkin dependencies #17615
Conversation
@vmartowicz Can you remove the package-lock.json file? |
generators/server/templates/src/main/resources/config/application-dev.yml.ejs
Outdated
Show resolved
Hide resolved
6c2a290
to
d402b3e
Compare
@vmartowicz Do not forget to remove the changes of the package-lock.json file |
d402b3e
to
8b75e43
Compare
8b75e43
to
1260e3b
Compare
@vmartowicz Can you update the snapshot files? |
@DanielFran When I run the asked command, I got the attached errors. What do I need to do? |
1260e3b
to
68017bb
Compare
@DanielFran |
Need to run |
Rebase or merge from upstream before, otherwise the snapshot may be outdated. |
I will try again |
68017bb
to
235b34e
Compare
@mshima @DanielFran Hi I succeed to update my snapshots but some frontend tests failed with the following message.
I see some other PR with the same tests failed. Is it normal? Or do I need to do something? |
Transitional dependency failure angular/angular-cli#22606. |
@mshima angular/angular-cli#22606. is closed. |
235b34e
to
765cb25
Compare
@vmartowicz I've rebased and updated the snapshots. |
@mshima thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t know about zipkin.
The PR looks ok.
fix #17487
This pull request :
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.