Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sleuth/zipkin dependencies #17615

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

vmartowicz
Copy link
Contributor

fix #17487

This pull request :

  • fixes the wrong zipkin dependency
  • fixes sleuth async executor
  • add a docker compose zipkin

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added theme: dependencies Pull requests that update a dependency file theme: java theme: jhipster-internals labels Jan 19, 2022
@DanielFran
Copy link
Member

@vmartowicz Can you remove the package-lock.json file?

@vmartowicz vmartowicz force-pushed the fix/17487-sleuth-zipkin branch from 6c2a290 to d402b3e Compare January 20, 2022 12:32
@DanielFran
Copy link
Member

@vmartowicz Do not forget to remove the changes of the package-lock.json file

@vmartowicz vmartowicz force-pushed the fix/17487-sleuth-zipkin branch from d402b3e to 8b75e43 Compare January 20, 2022 18:31
@github-actions github-actions bot removed the theme: dependencies Pull requests that update a dependency file label Jan 20, 2022
@vmartowicz vmartowicz force-pushed the fix/17487-sleuth-zipkin branch from 8b75e43 to 1260e3b Compare January 21, 2022 09:14
@DanielFran
Copy link
Member

@vmartowicz
Copy link
Contributor Author

@DanielFran When I run the asked command, I got the attached errors. What do I need to do?

generator-jhipster-17487.txt
?

@vmartowicz vmartowicz force-pushed the fix/17487-sleuth-zipkin branch from 1260e3b to 68017bb Compare January 23, 2022 20:58
@vmartowicz
Copy link
Contributor Author

@DanielFran
I m always getting the same error. I don't know what to do....

@mshima
Copy link
Member

mshima commented Jan 27, 2022

Need to run npm run update-snapshots.

@mshima
Copy link
Member

mshima commented Jan 27, 2022

Rebase or merge from upstream before, otherwise the snapshot may be outdated.

@vmartowicz
Copy link
Contributor Author

Rebase or merge from upstream before, otherwise the snapshot may be outdated.
yes I did it

Need to run npm run update-snapshots.
Yes but I got the attached errors

I will try again

@vmartowicz vmartowicz force-pushed the fix/17487-sleuth-zipkin branch from 68017bb to 235b34e Compare January 29, 2022 23:49
@vmartowicz
Copy link
Contributor Author

@mshima @DanielFran Hi I succeed to update my snapshots but some frontend tests failed with the following message.

  • ngx-infinite-scroll [es2015/esm2015] (https://github.com/orizens/ngx-infinite-scroll.git)
    ✔ Browser application bundle generation complete.
    An unhandled exception occurred: Transform failed with 1 error:
    error: Invalid version: "15.2-15.3"
    See "/tmp/ng-HryzP3/angular-errors.log" for further details.
    ##[error]Bash exited with code '127'.
    Finishing: TESTS: frontend

I see some other PR with the same tests failed. Is it normal? Or do I need to do something?

@mshima
Copy link
Member

mshima commented Jan 30, 2022

Transitional dependency failure angular/angular-cli#22606.
Should be fixed soon.

@vmartowicz
Copy link
Contributor Author

@mshima angular/angular-cli#22606. is closed.
Do I need to do something?

@mshima mshima closed this Feb 1, 2022
@mshima mshima reopened this Feb 1, 2022
@mshima mshima force-pushed the fix/17487-sleuth-zipkin branch from 235b34e to 765cb25 Compare February 1, 2022 20:22
@mshima
Copy link
Member

mshima commented Feb 1, 2022

@vmartowicz I've rebased and updated the snapshots.

@vmartowicz
Copy link
Contributor Author

@mshima thanks

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know about zipkin.
The PR looks ok.

@mshima mshima merged commit 6879951 into jhipster:main Feb 7, 2022
@pascalgrimaud pascalgrimaud added this to the 7.7.0 milestone Feb 8, 2022
@vmartowicz vmartowicz deleted the fix/17487-sleuth-zipkin branch February 8, 2022 13:16
ko5tik pushed a commit to ko5tik/generator-jhipster that referenced this pull request May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to start microservice application with sleuth/zipkin enabled
5 participants