-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHY] Staged modes #1414
Merged
Merged
[PHY] Staged modes #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice - I call this a digital-twin - saves so much time with some of the more complex ADC chips - the drivers just love to read settings, alter a few bits, put it back, do that for 8+ settings and ... yawn ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: When switching between modes (e.g. from standby to receive) there is a significant overhead of commands that must be sent to the device to configure it. Such overhead adds timing uncertainty, because there is a not-insignificant delay between calling the appropriate method (e.g.
startReceive
) and the device actually starting being able to receive packets. The issue becomes more significant at low clock/SPI speeds typically used in battery-powered devices. This causes problems especially for LoRaWAN.This PR adds support for "staged modes". This is an API of the
PhysicalLayer
class that allow to "stage" a mode to be set by callingstageMode
method, and then "launching" this mode withlaunchMode
that only performs a couple of SPI transactions.Marking as draft for now since there is still some cleanup left to be done.