[LoRaWAN] Add methods to allow user-provided sleep function #1410
Conversation
|
We could a-synchronize the transmission calls - at SF9+ they could easily rise above the threshold too. Requires a pre-calculation of the timeout value but this is done anyway on Fixed bands (US915-style) for the Dwell time limits so I guess we can do that for Dynamic (EU868-style) as well. |
|
@jgromes I added a commit in the new branch. I know that that is not ideal, but given that I was working on that anyway (and needed asynchronous calls to work around an erroneous cast), I thought I'd add that there. Feel free to port that over if you want to close this first, otherwise we must merge this manually after the mode staging is done. |
|
@jgromes Would be nice to add this in reference example - of course with the "warning note" ... ;) |
* [PHY] Add PHY support for staged modes * [SX126x] Add support for staged Rx/Tx * [PHY] Add missing virtual specifiers * [SX126x] Add missing overrides * [LoRaWAN] Use new stageMode and launchMode, reduce scanGuard * [LoRaWAN] A-synchronize transmissions (#1410) * [PHY] Pass mode config by reference * [PHY] Add default implementation of start transmit/receive * [SX126x] Implement staged modes * [SX128x] Implement staged modes * [SX127x] Implement staged modes * [LR11x0] Implement staged modes * [SX127x] Remove unused method from header * [SX126x] Make array const * Add new methods to keywords --------- Co-authored-by: StevenCellist <[email protected]>
|
@jgromes will you add it in the transmission as well, or shall I do that? |
|
@StevenCellist yes please! And anywhere else you find it appropriate. |
|
Turns out every one of the delays could potentially be longer than a few (tens of) milliseconds, so they're now all |
|
@StevenCellist thank you so much - indeed, we'll see how well this works ;) |
Discussed in #1401
cc @StevenCellist - so far I only used this function in the Rx windows, are there others where this would make sense? And should we add this to the reference example?