-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java 17 to build/test matrix #168
Conversation
Used my admin powers to replay the build with the |
315b286
to
5cb76f0
Compare
[platform: 'linux', jdk: 17], | ||
[platform: 'windows', jdk: 11], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the archetype.
@@ -4,7 +4,7 @@ | |||
<parent> | |||
<groupId>org.jenkins-ci.plugins</groupId> | |||
<artifactId>plugin</artifactId> | |||
<version>4.50</version> | |||
<version>4.63</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest at the time of this writing.
@@ -37,15 +37,15 @@ | |||
<revision>2.31</revision> | |||
<changelist>-SNAPSHOT</changelist> | |||
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo> | |||
<jenkins.version>2.332.4</jenkins.version> | |||
<jenkins.version>2.361.4</jenkins.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimum version supported by the latest plugin parent POM.
<artifactId>bom-2.361.x</artifactId> | ||
<version>2081.v85885a_d2e5c5</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest at the time of this writing.
@@ -45,7 +45,6 @@ | |||
import org.acegisecurity.providers.UsernamePasswordAuthenticationToken; | |||
import org.acegisecurity.userdetails.UserDetails; | |||
import org.acegisecurity.userdetails.UsernameNotFoundException; | |||
import org.codehaus.mojo.animal_sniffer.IgnoreJRERequirement; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Animal Sniffer has been removed from the latest plugin parent POM.
@@ -10,6 +11,7 @@ | |||
import static org.junit.Assert.assertNotNull; | |||
import static org.junit.Assert.assertTrue; | |||
|
|||
@Ignore("setting environment variables is not supported in Java 17") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN ln -s /usr/lib/libfontconfig.so.1 /usr/lib/libfontconfig.so && \ | ||
ln -s /lib/libuuid.so.1 /usr/lib/libuuid.so.1 && \ | ||
ln -s /lib/libc.musl-x86_64.so.1 /usr/lib/libc.musl-x86_64.so.1 | ||
FROM docker:dind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stable-dind
image is no longer available or maintained.
ln -s /lib/libuuid.so.1 /usr/lib/libuuid.so.1 && \ | ||
ln -s /lib/libc.musl-x86_64.so.1 /usr/lib/libc.musl-x86_64.so.1 | ||
FROM docker:dind | ||
RUN apk add --no-cache fontconfig ttf-dejavu openjdk11 bash tini bind-tools maven |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous workarounds are no longer necessary in a modern image.
Closing in favor of #170. |
No description provided.